(0.94.1) Refactor SplitExplicitFreeSurface
#3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the comments, I should have addressed all points. |
glwagner
reviewed
Nov 14, 2024
Comment on lines
61
to
62
|
|
||
| Gⁿ⁺¹ = @inbounds C₁ * Gⁿ[i, j, k] - C₂ * G⁻[i, j, k] |
There was a problem hiding this comment.
Suggested change
| Gⁿ⁺¹ = @inbounds C₁ * Gⁿ[i, j, k] - C₂ * G⁻[i, j, k] | |
| not_euler = C₂ != 0 | |
| Gⁿ⁺¹ = @inbounds C₁ * Gⁿ[i, j, k] - C₂ * G⁻[i, j, k] * not_euler |
multiplying by false eliminates the NaN
(we need this in the other time-stepping code too)
glwagner
approved these changes
Nov 14, 2024
glwagner
reviewed
Nov 14, 2024
...Models/HydrostaticFreeSurfaceModels/SplitExplicitFreeSurfaces/split_explicit_free_surface.jl
Outdated
Show resolved
Hide resolved
glwagner
reviewed
Nov 14, 2024
...Models/HydrostaticFreeSurfaceModels/SplitExplicitFreeSurfaces/split_explicit_free_surface.jl
Outdated
Show resolved
Hide resolved
…ces/split_explicit_free_surface.jl Co-authored-by: Gregory L. Wagner <[email protected]>
…ces/split_explicit_free_surface.jl Co-authored-by: Gregory L. Wagner <[email protected]>
|
I think was merged with a bump to 0.94.1 before 0.94 was registered. How do we fix this? |
|
we have to merge 0.94 retroactively. But yeah, this should have been merged just as 0.94, not 0.94.1 @simone-silvestri . |
|
We don't need to fix. It's OK. We move on. |
|
Oh sorry, my bad! I messed up a bit here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring of the
SplitExplicitFreeSurfaceto comply with issue #3873Additional changes included in this PR not described in #3873:
Connectedtopology (FullyConnected,RightConnectedorLeftConnected) so there is no need to extend the constructor for grids (such as distributed grids) that have connected topologies.ExplicitFreeSurfacerelevant code has been moved in theexplicit_free_surface.jlfile